Python codegen: support for Transform3D #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2023
teh-cmc
added a commit
that referenced
this pull request
Jul 11, 2023
- Introduce IDL definitions for the `Transform3D` family of types - Fixes the top-level nullable union field in struct mess + add related fuzzing test cases - Fixes an issue with arrays of booleans + add related fuzzing test case - Fixes an issue with lists and fixed-size lists of transparent objects + add related fuzzing test case - Other fixes and improvements, see commits Required for #2639 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2654) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2654) - [Docs preview](https://rerun.io/preview/pr%3Acmc%2Frust_codegend_transforms/docs) - [Examples preview](https://rerun.io/preview/pr%3Acmc%2Frust_codegend_transforms/examples) --------- Co-authored-by: Antoine Beyeler <[email protected]>
…some pyright errors
…ython 3.8 compatibility
[skip ci]
abey79
force-pushed
the
antoine/hope-python-transforms-new
branch
from
b236faa to
37c188e
Compare
jleibs
approved these changes
Jul 13, 2023
teh-cmc
added a commit
that referenced
this pull request
Jul 19, 2023
**Commit by commit!** This PR makes it so Python and Rust can exchange `Transform3D` data using the new Archetype-based APIs. Roughly: - Fixes serialization issues in Python SDK - Implements all necessary Rust extensions - Improves our roundtrip test suite - Implements cross-language roundtrip tests for `Transform3D` Fixes #2644 Requires: - #2639 - #2673 - #2708 --- ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2669) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2669) - [Docs preview](https://rerun.io/preview/pr%3Acmc%2Fhope_rust_transforms/docs) - [Examples preview](https://rerun.io/preview/pr%3Acmc%2Fhope_rust_transforms/examples) --------- Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for
Transform3Dto the new-gen Python SDK, including:disallow_untyped_calls = Falsein.mypy.ini)Note:
from_parentfield is moved fromTransform3Dto bothTranslation*objects, to comply with the 1-comp-1-datatype rule.from_parentfield has been madenullablethough it has a default value, which are not yet implemented (Parse default values during semantic pass #2641).TODO:
rr.arch.Transform3D()serialisation testsfrom_parent) (including proper field sorting)ruff --fixseems to always failTODO @teh-cmc and/or @jleibs :
rerun_py/src/arrow.rsrequiredanymore, introducenullableinstead #2619)python.rs)Checklist