New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full support for `Transform3D` archetype in Rust #2644

Closed

2 of 6 tasks

teh-cmc opened this issue Jul 10, 2023 · 0 comments · Fixed by #2669

Closed

2 of 6 tasks

Full support for `Transform3D` archetype in Rust #2644

teh-cmc opened this issue Jul 10, 2023 · 0 comments · Fixed by #2669

Assignees

Labels

codegen/idl 🦀 Rust API

Member

teh-cmc commented Jul 10, 2023 •

edited

Loading

Code is generated successfully
There's a unit test in place for Rust-to-Rust serialization roundtrips
The archetype has been backported to the existing SDK
- MsgSender::with_component(re_components::Transform{..}) still works
- MsgSender::from_archetype(re_types::Transform3D) works as well
test_api has been updated to use re_types::Transform3D instead

The text was updated successfully, but these errors were encountered:

teh-cmc added 🦀 Rust API codegen/idl labels

teh-cmc self-assigned this

This was referenced Jul 10, 2023

Transform3D cross-language roundtrip tests #2645

Closed

Roundtrip-able Transform3Ds #2669

Merged

teh-cmc closed this as completed in #2669

teh-cmc added a commit that referenced this issue


          Roundtrip-able Transform3Ds (#2669)

edaf2e1

**Commit by commit!**

This PR makes it so Python and Rust can exchange `Transform3D` data
using the new Archetype-based APIs.

Roughly:
- Fixes serialization issues in Python SDK
- Implements all necessary Rust extensions
- Improves our roundtrip test suite
- Implements cross-language roundtrip tests for `Transform3D`

Fixes #2644 

Requires:
- #2639 
- #2673
- #2708 

---

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2669) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2669)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Fhope_rust_transforms/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fhope_rust_transforms/examples)

---------

Co-authored-by: Jeremy Leibs <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment