Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BGR/RGB mixup in colmap example #2430

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Fix BGR/RGB mixup in colmap example #2430

merged 1 commit into from
Jun 14, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Jun 14, 2023

What

Bug introduced in #2418

It's back to being red:
image

Checklist

PR Build Summary: https://build.rerun.io/pr/2430

Docs preview: https://rerun.io/preview/df06d4c/docs
Examples preview: https://rerun.io/preview/df06d4c/examples

@emilk emilk added 🪳 bug Something isn't working examples Issues relating to the Rerun examples labels Jun 14, 2023
@emilk emilk merged commit 951e84a into main Jun 14, 2023
@emilk emilk deleted the emilk/fix-bgr branch June 14, 2023 14:17
emilk added a commit that referenced this pull request Jun 15, 2023
### What
Bug introduced in #2418

It's back to being red:

![image](https://github.com/rerun-io/rerun/assets/1148717/9ce4ab6b-a782-4b0d-9f75-2c905bf3313e)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2430

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/df06d4c/docs
Examples preview: https://rerun.io/preview/df06d4c/examples
<!-- pr-link-docs:end -->
@emilk emilk mentioned this pull request Jun 15, 2023
3 tasks
@emilk emilk changed the title Fix BGR/RGB mixup in colmap demo Fix BGR/RGB mixup in colmap example Jun 15, 2023
@emilk emilk mentioned this pull request Jun 15, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants