Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce from __future__ import annotations in Python files #2377

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jun 12, 2023

What

Follow-up to #2361:

  • Add a Ruff rule to check/add from __future__ import annotations everywhere.
  • Normalise a bunch of python files (mainly scripts) that the previous PR missed.

Checklist

PR Build Summary: https://build.rerun.io/pr/2377

Docs preview: https://rerun.io/preview/2c443d9/docs
Examples preview: https://rerun.io/preview/2c443d9/examples

@abey79 abey79 added 🐍 Python API Python logging API 🧑‍💻 dev experience developer experience (excluding CI) labels Jun 12, 2023
@abey79 abey79 merged commit f0610a6 into main Jun 12, 2023
@abey79 abey79 deleted the antoine/future-annotations-ruff branch June 12, 2023 08:13
emilk pushed a commit that referenced this pull request Jun 15, 2023
### What

Follow-up to #2361:

- Add a Ruff rule to check/add `from __future__ import annotations`
everywhere.
- Normalise a bunch of python files (mainly scripts) that the previous
PR missed.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [ ] I've included a screenshot or gif (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2377

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/2c443d9/docs
Examples preview: https://rerun.io/preview/2c443d9/examples
<!-- pr-link-docs:end -->
This was referenced Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants