Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-half pixel error in textured rectangle shader #2294

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix off-by-half pixel error in textured rectangle shader #2294

merged 1 commit into from
May 31, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 31, 2023 •
edited by github-actions bot
Loading

What

Closes #2236

I made a 4x4 test image to verify:
Screenshot 2023-05-31 at 19 21 21

Checklist

PR Build Summary: https://build.rerun.io/pr/2294

Docs preview: https://rerun.io/preview/dd724f5/docs

@emilk emilk added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself labels May 31, 2023
Wumpf
Wumpf approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. makes sense when one thinks about it.
(The kind of hindsight-sense where the opposite result would convince me as well, hehe)

@Wumpf Wumpf merged commit b4e8701 into main May 31, 2023
@Wumpf Wumpf deleted the emilk/fix-off-by-half-pixel branch May 31, 2023 17:42
emilk added a commit that referenced this pull request Jun 15, 2023
@emilk
Fix off-by-half pixel error in textured rectangle shader (#2294)
beb6350 
### What
Closes #2236

I made a 4x4 test image to verify:
<img width="1189" alt="Screenshot 2023-05-31 at 19 21 21"
src="https://github.com/rerun-io/rerun/assets/1148717/9b0f390a-7da2-4ae2-81b9-8789ea07fec2">

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2294

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/dd724f5/docs
<!-- pr-link-docs:end -->
This was referenced Jun 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2D image detail is half a pixel off
2 participants
@emilk @Wumpf