Time panel now always talks about "events" instead of "messages" #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under the hood this is nuanced and we don't always get the names right: An Event is a set of component changes for a single given entity at a single given timepoint. A Message on the other hand is something we send from api to store and may contain many of these Events and potentially other things.
emilk
approved these changes
May 29, 2023
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
Tiny follow-up to #2233 Under the hood this is nuanced and we don't always get the names right: An Event is a set of component changes for a single given entity at a single given timepoint. A Message on the other hand is something we send from api to store and may contain many of these Events and potentially other things. That said, I didn't find other occurrences where this is clearly labeled incorrectly, but there gotta be more! ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny follow-up to #2233
Under the hood this is nuanced and we don't always get the names right: An Event is a set of component changes for a single given entity at a single given timepoint. A Message on the other hand is something we send from api to store and may contain many of these Events and potentially other things.
That said, I didn't find other occurrences where this is clearly labeled incorrectly, but there gotta be more!
What
Checklist
PR Build Summary: https://build.rerun.io/pr/2247