Fix manual release/dispatch workflows #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use |
emilk
approved these changes
May 30, 2023
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What - `manual_build_release` now includes `reusable_build_web_demo`/`reusable_upload_web_demo` - `manual_release` now uploads the the commit from `rerun-demo/commit/<commit>` to `/version/latest` - bandaid for breaking `manual_dispatch`: changed `BUILD_WEB` input in `manual_dispatch` to accept a string instead of a bool (example values: `app`, `demo`, `app,demo`), and removed `BUILD_WEB_DEMO` - without this the number of inputs exceeds 10 and the workflow is invalid and cannot be used - bandaid to ensure `adhoc_web` will not overwrite the latest commit build: added `UPLOAD_COMMIT` input to `upload_web` and `upload_web_demo` which is on by default, and set it to false in `manual_adhoc_web` ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] I've included a screenshot or gif (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
manual_build_releasenow includesreusable_build_web_demo/reusable_upload_web_demomanual_releasenow uploads the the commit fromrerun-demo/commit/<commit>to/version/latestmanual_dispatch: changedBUILD_WEBinput inmanual_dispatchto accept a string instead of a bool (example values:app,demo,app,demo), and removedBUILD_WEB_DEMOadhoc_webwill not overwrite the latest commit build: addedUPLOAD_COMMITinput toupload_webandupload_web_demowhich is on by default, and set it to false inmanual_adhoc_webChecklist
PR Build Summary: https://build.rerun.io/pr/2230