Fix double clicking objects no longer focusing the camera on them #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
May 29, 2023
| @@ -47,9 +47,6 @@ pub struct View3DState { | |||
|
|
|||
| eye_interpolation: Option<EyeInterpolation>, | |||
|
|
|||
| /// Where in world space the mouse is hovering (from previous frame) | |||
| hovered_point: Option<glam::Vec3>, | |||
There was a problem hiding this comment.
Ouch, I would had hoped clippy would have caught a field only being read from
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
) _Requires #2188_ ✔️ Fixes #2215 * #2215 * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2188 ✔️
Fixes #2215
What
Checklist
PR Build Summary: https://build.rerun.io/pr/2227