Stable image order, fixing flickering #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📺 re_viewer
emilk
requested changes
May 23, 2023
crates/re_viewer/src/ui/view_spatial/scene/scene_part/images.rs
Outdated
Show resolved
Hide resolved
crates/re_viewer/src/ui/view_spatial/scene/scene_part/images.rs
Outdated
Show resolved
Hide resolved
…e walk in order to simplify image grouping
emilk
reviewed
May 24, 2023
crates/re_viewer/src/ui/view_spatial/scene/scene_part/images.rs
Outdated
Show resolved
Hide resolved
emilk
approved these changes
May 24, 2023
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
* deterministic order of depth offset determination * improved way of grouping images * memorize pinhole camera to which entities belong during transform tree walk in order to simplify image grouping * merge sort functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes image flickering on draw order demo.
This is likely related to #2104 but I think the fix here is a good idea regardless.
For some reason I only reproed the flickering on web but I couldn't find anything inherently web about it.
Checklist
PR Build Summary: https://build.rerun.io/pr/2191