Remove native_viewer from the default features of rerun crate
#2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1997 Most of our users only use the `rerun` library as a logging library but are still paying the cost of compiling the native viewer. With this PR, the `rerun` crate will not have the `native_viewer` (not `web_viewer`) feature on by default. This halves the compilation time on my computer. The `native_viewer` feature is only for users using the `show` or `spawn` features, which will hopefully be removed soon anyay: * #2109 To install the `rerun` binary with `native_viewer` and `web_viewer`, you now have to run `cargo install rerun --features binary`. This will be improved by: * #2108 To make things nicer for us developers, I've added `cargo rerun` as a shorthand for compiling and running `rerun` with the `native_viewer` feature, but NOT the `web_viewer` feature.
emilk
added
🦀 Rust API
|
If you now have to install the target with different flags from used in the common library case I'm not sure I see a material value compared to just having a dedicated viewer crate:
|
|
Yeah, |
|
I'm trying it out in #2183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1997
What
Most of our users only use the
rerunlibrary as a logging library but are still paying the cost of compiling the native viewer.With this PR, the
reruncrate will not have thenative_viewer(norweb_viewer) feature on by default. This halves the compilation time on my computer. It also reduces the chance of crate mismatch (we've had users complaining about us using an olderwgputhan they, even though they only usererunfor logging).The
native_viewerfeature is only for users using theshoworspawnfeatures, which will hopefully be removed soon anyway:spawnin favor of fork-exec + binary artifacts #2109To install the
rerunbinary withnative_viewerandweb_viewer, you now have to runcargo install rerun --features binary. This will be improved by:rerunbinaries on popular package managers #2108To make things nicer for us developers, I've added
cargo rerunas a shorthand for compiling and runningrerunwith thenative_viewerfeature, but NOT theweb_viewerfeature.Checklist
PR Build Summary: https://build.rerun.io/pr/2177