-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust SDK: remove old threaded spawn
in favor of fork-exec + binary artifacts
#2109
Closed
Tracked by
#3942
Labels
🦀 Rust API
Rust logging API
Comments
emilk
added a commit
that referenced
this issue
May 20, 2023
Closes #1997 Most of our users only use the `rerun` library as a logging library but are still paying the cost of compiling the native viewer. With this PR, the `rerun` crate will not have the `native_viewer` (not `web_viewer`) feature on by default. This halves the compilation time on my computer. The `native_viewer` feature is only for users using the `show` or `spawn` features, which will hopefully be removed soon anyay: * #2109 To install the `rerun` binary with `native_viewer` and `web_viewer`, you now have to run `cargo install rerun --features binary`. This will be improved by: * #2108 To make things nicer for us developers, I've added `cargo rerun` as a shorthand for compiling and running `rerun` with the `native_viewer` feature, but NOT the `web_viewer` feature.
emilk
added a commit
that referenced
this issue
May 20, 2023
Closes #1997 Most of our users only use the `rerun` library as a logging library but are still paying the cost of compiling the native viewer. With this PR, the `rerun` crate will not have the `native_viewer` (not `web_viewer`) feature on by default. This halves the compilation time on my computer. The `native_viewer` feature is only for users using the `show` or `spawn` features, which will hopefully be removed soon anyay: * #2109 To install the `rerun` binary with `native_viewer` and `web_viewer`, you now have to run `cargo install rerun --features binary`. This will be improved by: * #2108 To make things nicer for us developers, I've added `cargo rerun` as a shorthand for compiling and running `rerun` with the `native_viewer` feature, but NOT the `web_viewer` feature.
1 task
emilk
added a commit
that referenced
this issue
May 22, 2023
Closes #1997 Most of our users only use the `rerun` library as a logging library but are still paying the cost of compiling the native viewer. With this PR, the `rerun` crate will not have the `native_viewer` (not `web_viewer`) feature on by default. This halves the compilation time on my computer. The `native_viewer` feature is only for users using the `show` or `spawn` features, which will hopefully be removed soon anyay: * #2109 To install the `rerun` binary with `native_viewer` and `web_viewer`, you now have to run `cargo install rerun --features binary`. This will be improved by: * #2108 To make things nicer for us developers, I've added `cargo rerun` as a shorthand for compiling and running `rerun` with the `native_viewer` feature, but NOT the `web_viewer` feature.
emilk
added a commit
that referenced
this issue
May 23, 2023
* Remove `native_viewer` from the default features of `rerun` crate Closes #1997 Most of our users only use the `rerun` library as a logging library but are still paying the cost of compiling the native viewer. With this PR, the `rerun` crate will not have the `native_viewer` (not `web_viewer`) feature on by default. This halves the compilation time on my computer. The `native_viewer` feature is only for users using the `show` or `spawn` features, which will hopefully be removed soon anyay: * #2109 To install the `rerun` binary with `native_viewer` and `web_viewer`, you now have to run `cargo install rerun --features binary`. This will be improved by: * #2108 To make things nicer for us developers, I've added `cargo rerun` as a shorthand for compiling and running `rerun` with the `native_viewer` feature, but NOT the `web_viewer` feature. * Add rerun-cli Users will now install the `rerun` binary with `cargo install rerun-cli` * Add a README.md * better text about how to run examples Co-authored-by: Andreas Reich <[email protected]> * Improve docs * Update RELEASES.md * Add checking of the docs to the release process --------- Co-authored-by: Andreas Reich <[email protected]>
emilk
added a commit
that referenced
this issue
May 25, 2023
* Remove `native_viewer` from the default features of `rerun` crate Closes #1997 Most of our users only use the `rerun` library as a logging library but are still paying the cost of compiling the native viewer. With this PR, the `rerun` crate will not have the `native_viewer` (not `web_viewer`) feature on by default. This halves the compilation time on my computer. The `native_viewer` feature is only for users using the `show` or `spawn` features, which will hopefully be removed soon anyay: * #2109 To install the `rerun` binary with `native_viewer` and `web_viewer`, you now have to run `cargo install rerun --features binary`. This will be improved by: * #2108 To make things nicer for us developers, I've added `cargo rerun` as a shorthand for compiling and running `rerun` with the `native_viewer` feature, but NOT the `web_viewer` feature. * Add rerun-cli Users will now install the `rerun` binary with `cargo install rerun-cli` * Add a README.md * better text about how to run examples Co-authored-by: Andreas Reich <[email protected]> * Improve docs * Update RELEASES.md * Add checking of the docs to the release process --------- Co-authored-by: Andreas Reich <[email protected]>
This was referenced Oct 20, 2023
teh-cmc
added a commit
that referenced
this issue
Oct 26, 2023
…mples (#3997) - Get rid of the old thread-based `spawn` functionality. - Redesign `RerunArgs` to get rid of the awful callback while still dealing with Tokio's TLS shenanigans. - Update all tests and examples. The new `RerunArgs` combined with the new `spawn` from PATH now make for a pretty nice experience: ```rust let args = Args::parse(); let (rec, _serve_guard) = args.rerun.init("my_app")?; // do stuff with rec ``` --- Spawn via `$PATH` series: - #3996 - #3997 - #3998 --- - Fixes #2109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requires #2107
The text was updated successfully, but these errors were encountered: