Centralize freestanding store helpers #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
⛃ re_datastore
teh-cmc
commented
May 16, 2023
| let component = iter.next(); | ||
|
|
||
| if iter.next().is_some() { | ||
| re_log::warn_once!("Unexpected batch for {} at: {}", C::name(), entity_path); |
crates/re_query/src/query.rs
Outdated
| @@ -79,7 +79,7 @@ pub fn get_component_with_instances( | |||
| /// length. | |||
| /// | |||
| /// If you expect only one instance (e.g. for mono-components like `Transform` `Tensor`] | |||
| /// and have no additional components you can use [`re_data_store::query_latest_single`] instead. | |||
| /// and have no additional components you can use [`re_data_store::query_latest_component`] instead. | |||
I definitely don't mind handling the annoying rebase if needed |
jleibs
approved these changes
May 17, 2023
teh-cmc
force-pushed
the
cmc/centralize_helpers
branch
from
2d04d5c to
6edf777
Compare
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
* centralize freestanding store helpers * port everything to new helpers * note to self * missing feature flag * docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a trivial PR to centralize a bunch of freestanding helpers and improve discoverability / autocomplete etc.
Related to #2019 (if we're very generous)
PR Build Summary: https://build.rerun.io/pr/2153