Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: allow hovered items to be clicked to set selection #2057

Merged
merged 1 commit into from
May 5, 2023
Merged

Bugfix: allow hovered items to be clicked to set selection #2057

merged 1 commit into from
May 5, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented May 5, 2023 •
edited by github-actions bot
Loading

Fixes a regression from: #2048

The new logic meant click was ignored since we would always hit the hover path of the if/else and never evaluate clicked.

Checklist

PR Build Summary: https://build.rerun.io/pr/2057

@jleibs jleibs added 🪳 bug Something isn't working ui concerns graphical user interface labels May 5, 2023
@jleibs jleibs marked this pull request as ready for review May 5, 2023 18:04
Wumpf
Wumpf approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! Bringing this function back was a late addition to the pr and wasn't properly tested apparently

@Wumpf Wumpf merged commit c7a1a44 into main May 5, 2023
@Wumpf Wumpf deleted the jleibs/fix_selection branch May 5, 2023 18:31
@Wumpf Wumpf added the 🦟 regression A thing that used to work in an earlier release label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleibs @Wumpf