[pure refactor] move data ui to new re_data_ui crate
#2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📺 re_viewer
emilk
approved these changes
May 5, 2023
There was a problem hiding this comment.
I'm not too happy about select_hovered_on_click dissappearing and being spread around the code base. It's not the code duplication, it is the repeated logic that will make it more difficult to change what happens on cmd-click, shift-click, etc.
On another note: have you tried running cargo machete to find unused dependencies?
Comment on lines
+18
to
+19
| // TODO(andreas): Move to its own crate? | ||
| pub mod gpu_bridge; |
There was a problem hiding this comment.
the thought has occurred to me too - a re_renderer <-> re_log_types bridge crate.
did now and found a lil bit :) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new crate
re_data_uiwhich depends onre_viewer_contextand is in turn used byre_viewer.This didn't go nowhere nearly as smoothly as expected. I had to move more things into
re_viewer_contextfor the time being than I wanted, but nothing too outrageous. It does makere_viewer_contextquite a lot bigger though than I wanted. The main issue was around supporting tensor ui inre_data_ui- due to the way data ui is setup up, the orphan rule right now forces us to put all data ui intore_data_ui.On the bright side, the things moved make the main viewer crate once more leaner, making it easier to move more.
Part of:
re_viewer#1873What
Checklist
PR Build Summary: https://build.rerun.io/pr/2048