[pure refactor] Move ViewerContext & ComponentUiRegistry to viewer_context
#2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📺 re_viewer
|
oops, pusehd stuff in here that should go into a separate PR. Rolling back... |
Wumpf
force-pushed
the
andreas/move-viewer_context
branch
from
93da499 to
6f0368d
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another part of:
re_viewer#1873This is a major milestone: We now can move out more crates out of re_viewer that only depend on the viewer context.
Sadly, this introduces a gui dependency to
re_viewer_contextthat I wanted to avoid, but I couldn't figure out how to do that. It gets quite complex. But I opted to at least have almost zero ui setup code inre_viewer_contextNext step is now to move the
data_uifolder to a separate crate. If I'm not mistaken this should be very easy nowNext step after that is to move the timeline to a separate crate which should in turn be then quite easy 🤞
What
Checklist
PR Build Summary: https://build.rerun.io/pr/2047