Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pure refactor] move time control to re_viewer_context #2045

Merged
merged 3 commits into from
May 4, 2023
Merged

[pure refactor] move time control to re_viewer_context #2045

merged 3 commits into from
May 4, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 4, 2023

Yet another part of:

getting very close now to moving over the ViewerContext itself. Likely in the next PR!

PR very similar to

Checklist

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality labels May 4, 2023
emilk
emilk approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeet

@Wumpf Wumpf merged commit 141d717 into main May 4, 2023
@Wumpf Wumpf deleted the andreas/move-time-control branch May 4, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @emilk