Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an sRGB-correct gray gradient when displaying grayscale images #2014

Merged
merged 5 commits into from
May 2, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 1, 2023

Closes #1990

This also means using the grayscale colormap for tensors result in a more perceptually even gradient, which is good.

image

Checklist

PR Build Summary: https://build.rerun.io/pr/2014

This also means using the grayscale colormap for tensors result
in a more perceptually even gradient, which is good.
@emilk emilk added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself labels May 1, 2023
@emilk emilk merged commit 3212976 into main May 2, 2023
@emilk emilk deleted the emilk/fix-grayscale branch May 2, 2023 07:29
@emilk emilk mentioned this pull request May 2, 2023
jleibs pushed a commit that referenced this pull request May 2, 2023
…2014)

* Use an sRGB-correct gray gradient when displaying grayscale images

This also means using the grayscale colormap for tensors result
in a more perceptually even gradient, which is good.

* cleanup: import the correct shaders in the correct shader files

* Add explanatory comment

* Be explicit with clamp-to-edge address mode

* py-format
jleibs pushed a commit that referenced this pull request May 2, 2023
…2014)

* Use an sRGB-correct gray gradient when displaying grayscale images

This also means using the grayscale colormap for tensors result
in a more perceptually even gradient, which is good.

* cleanup: import the correct shaders in the correct shader files

* Add explanatory comment

* Be explicit with clamp-to-edge address mode

* py-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grayscale images has unexpected gamma
2 participants