Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grayscale images has unexpected gamma #1990

Closed
emilk opened this issue Apr 27, 2023 · 0 comments · Fixed by #2014
Closed

Grayscale images has unexpected gamma #1990

emilk opened this issue Apr 27, 2023 · 0 comments · Fixed by #2014
Assignees
@emilk
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself 🦟 regression A thing that used to work in an earlier release

Comments

@emilk
Copy link
Member

emilk commented Apr 27, 2023

We currently assume that all grayscale images are in linear space, which is a bad assumption. We should assume sRGB for u8 grayscale images.

Unfortunately there is no R8UnormSrgb texture format, so we need to handle this in the shader.
@emilk emilk added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself 🦟 regression A thing that used to work in an earlier release labels Apr 27, 2023
@emilk emilk self-assigned this May 1, 2023
@emilk emilk mentioned this issue May 1, 2023
Merged
2 tasks
@playreplayoliver playreplayoliver mentioned this issue Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use an sRGB-correct gray gradient when displaying grayscale images rerun-io/rerun
1 participant
@emilk