Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show 2D labels in 3D space views. #1641

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Don't show 2D labels in 3D space views. #1641

merged 2 commits into from
Mar 21, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 21, 2023

Fixes #1593
Being able to show them correctly requires #1640

Checklist

@Wumpf
Don't show 2D labels in 3D space views.
1c925a1 
Fixes #1593
Being able to show them correctly requires #1640
@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself labels Mar 21, 2023
emilk
emilk requested changes Mar 21, 2023
View reviewed changes
crates/re_viewer/src/ui/view_spatial/ui_3d.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/view_spatial/ui.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf requested a review from emilk March 21, 2023 14:57
@emilk
Copy link
Member

emilk commented Mar 21, 2023

nice re-use of existing enum!

@Wumpf Wumpf merged commit 0fcb0ad into main Mar 21, 2023
@Wumpf Wumpf deleted the andreas/dont-show-2d-labels-in-3d branch March 21, 2023 16:52
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2D label projected to incorrect location in 3D view
2 participants
@Wumpf @emilk