Fix crash on serve exit, second attempt #1633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to #1613.
New commit is separate - passing shutdown bool around in order to not infect everything with tokio.
It seems we almost never need to hook it up, somewhat suspicious but I couldn't find any missing case.
Testing list. All of these were tested on 13aad68
cargo r -p rerun -- ../nyud.rrd
cargo run -p rerun --features web_viewer -- ../api_demo.rrd --web-viewer
cargo run -p re_web_viewer_server
cargo run -p api_demo -- --serve
python ./examples/python/api_demo/main.py --serve
python -m rerun --web-viewer ../objectron.rrd
python ./examples/python/tracking_hf_opencv/main.py
cargo run -p api_demo
Checklist