Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the re_sdk_comms network code to use Tokio #1366

Closed
jondo2010 opened this issue Feb 21, 2023 — with Slack · 1 comment
Closed

Switch the re_sdk_comms network code to use Tokio #1366

jondo2010 opened this issue Feb 21, 2023 — with Slack · 1 comment

Comments

@jondo2010 Slack
Copy link
Contributor

<@U02US1A9RA9> probably a question for you: In crates/re_sdk_comms/src/server.rs , serve() spawns a thread waiting for incoming connections, and then 1 thread per connection from an incoming SDK. Is there any special reason this isn’t implemented with Tokio?

Slack Message
@jondo2010 jondo2010 mentioned this issue Feb 21, 2023
Closed
@emilk
Copy link
Member

emilk commented Mar 21, 2023

Closed by #1633

@emilk emilk closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jondo2010 @emilk