Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload web viewer to a bucket #1606

Merged
merged 10 commits into from
Mar 20, 2023
Merged

Upload web viewer to a bucket #1606

merged 10 commits into from
Mar 20, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 17, 2023 •
edited
Loading

Each merge to main will produce a web-viewer which is pushed to a google cloud bucket, which can be tested with:

https://storage.googleapis.com/rerun-web-viewer/web_viewer/index.html?url=https://storage.googleapis.com/rerun-example-rrd/test-rrd/fiat.rrd

Part of #1494

Checklist

@emilk emilk added the 🕸️ web regarding running the viewer in a browser label Mar 17, 2023
jleibs
jleibs reviewed Mar 17, 2023
View reviewed changes
.github/workflows/rust.yml Outdated Show resolved Hide resolved
jleibs
jleibs reviewed Mar 17, 2023
View reviewed changes
.github/workflows/rust.yml Outdated Show resolved Hide resolved
emilk
emilk commented Mar 17, 2023
View reviewed changes
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@nikolausWest
Copy link
Member

Test by putting the following url in your browser:
https://storage.googleapis.com/rerun-web-viewer/web_viewer/index.html?url=https://storage.googleapis.com/rerun-example-rrd/test-rrd/fiat.rrd

@emilk
Copy link
Member Author

emilk commented Mar 17, 2023

It works! https://storage.googleapis.com/rerun-web-viewer/web_viewer/index.html?url=https://storage.googleapis.com/rerun-example-rrd/test-rrd/fiat.rrd

@emilk emilk marked this pull request as ready for review March 17, 2023 15:19
@emilk emilk changed the title WIP: upload web viewer to a bucket Upload web viewer to a bucket Mar 17, 2023
Wumpf
Wumpf requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I'll add a manual trigger now, hold on :)
I'm also thinking that this should be either a separate action file or depend on the other jobs to ensure that we're not uploading something that didn't pass testing 🤔

Wumpf
Wumpf approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added manual trigger, plz check

@nikolausWest
Copy link
Member

Didn't check if this happens yet but we should make sure these are all put under versioned paths

@nikolausWest nikolausWest mentioned this pull request Mar 20, 2023
Closed
7 tasks
@jleibs jleibs force-pushed the emilk/upload-web-viewer branch from 952fab0 to d34609b Compare March 20, 2023 20:45
@jleibs jleibs force-pushed the emilk/upload-web-viewer branch from d34609b to 075db89 Compare March 20, 2023 21:00
@jleibs jleibs merged commit 0781ef5 into main Mar 20, 2023
@jleibs jleibs deleted the emilk/upload-web-viewer branch March 20, 2023 23:07
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs left review comments

@nikolausWest nikolausWest nikolausWest left review comments

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilk @nikolausWest @Wumpf @jleibs