Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve our web-viewer with one example somewhere #1494

Closed
9 tasks done
emilk opened this issue Mar 3, 2023 · 1 comment
Closed
9 tasks done

Serve our web-viewer with one example somewhere #1494

emilk opened this issue Mar 3, 2023 · 1 comment
Assignees
Labels
📺 re_viewer affects re_viewer itself 🕸️ web regarding running the viewer in a browser

Comments

@emilk
Copy link
Member

emilk commented Mar 3, 2023

Done when we can send a link to a friend without feeling embarrassed about it:

  • We have a nice URL with the web demo
    • Serve it as a static site using HTTPS load balancing (guide)
      • Point it to app.rerun.io
      • Turn on CDN
  • Our CI publish a new web-viewer and example .rrd files on each new release
    • Both are put in versioned locations in their respective buckets. These versions end up as part of the url
  • We warn about slowness on chrome (or fix it) (Chrome issue doesn't impact small rrds served over http. Only websockets.)
  • We warn about problems on Windows (or fix them)
  • We warn on mobile (our UI isn't designed for mobile yet)
  • We have links back to our landing page, github, and doc (Handle separately: Design and implement consistent linking between main site and app.rerun.io #1669)
  • Make sure analytics works so we can follow to what extent this feature is used

Potential complexities

  • SSL certificates: Should this use the same SSL certificate as our main site or not? If it should, that will require some extra work on the main site. If not, how will that work when we want to use this viewer to show Rerun examples on the main site?

Alternative approach to serving via a bucket

  • Serve with Netlify: We could use Netlify to serve the static web viewer. Would need to consider:
    • How would we set it up to work correctly with versions?
    • What would the deploy pipeline look like? Go through a separate repository?
    • This would remove the ssl certificate issue
@emilk emilk added 🕸️ web regarding running the viewer in a browser 📺 re_viewer affects re_viewer itself labels Mar 3, 2023
@emilk emilk changed the title Serve our web-viewer on rerun.io Serve our web-viewer with one hard-coded example somewhere Mar 3, 2023
@emilk emilk changed the title Serve our web-viewer with one hard-coded example somewhere Serve our web-viewer with one or a few examples somewhere Mar 20, 2023
@emilk emilk changed the title Serve our web-viewer with one or a few examples somewhere Serve our web-viewer with one examples somewhere Mar 20, 2023
@jleibs jleibs self-assigned this Mar 20, 2023
@jleibs
Copy link
Member

jleibs commented Mar 20, 2023

Note that the slowness of chrome is specifically related to the websocket data path. The url-downloading logic could still use a bit of optimization, but is not nearly as bad. Also it behaves much more similarly between firefox and chrome.

The 250-meg rusty_car.rrd takes 9 seconds to load on firefox, and 11 seconds to load on chrome. About 4 seconds of that is pre-fetching the 250-meg rrd, and the remaining 5-6 seconds are processing.

@emilk emilk changed the title Serve our web-viewer with one examples somewhere Serve our web-viewer with one example somewhere Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📺 re_viewer affects re_viewer itself 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

No branches or pull requests

3 participants