-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load .rrd file over HTTP #1600
Load .rrd file over HTTP #1600
Conversation
crates/re_viewer/src/lib.rs
Outdated
|
||
// Yield to other tasks | ||
async fn yield_() { | ||
sleep_ms(1).await; // TODO(emilk): create a better async yield function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue filed at rustwasm/wasm-bindgen#3359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but could use a bit of cleanup for the edge-cases around how we match a URL to a given handler.
Minimal working version.
It does not stream over HTTP - it downloads the full .rrd file before decoding it.
The
.rrd
file is then decoded progressively (important, since the decoding is pretty slow on web).Tested on web and native.
Part of #1494
Test native with
cargo r -p rerun -- some.rrd
Test web with:
Checklist