Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load .rrd file over HTTP #1600

Merged
merged 10 commits into from
Mar 17, 2023
Merged

Load .rrd file over HTTP #1600

merged 10 commits into from
Mar 17, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 16, 2023

Minimal working version.

It does not stream over HTTP - it downloads the full .rrd file before decoding it.

The .rrd file is then decoded progressively (important, since the decoding is pretty slow on web).

Tested on web and native.

Part of #1494

Test native with cargo r -p rerun -- some.rrd

Test web with:

python3 examples/python/colmap/main.py --dataset colmap_fiat --resize 800x600 --save web_viewer/fiat.rrd
cargo r -p re_build_web_viewer -- --release
(cd web_viewer && basic-http-server --addr 127.0.0.1:1234)
open "http://127.0.0.1:1234/?url=fiat.rrd"

Checklist

@emilk emilk added 🕸️ web regarding running the viewer in a browser 📺 re_viewer affects re_viewer itself labels Mar 16, 2023

// Yield to other tasks
async fn yield_() {
sleep_ms(1).await; // TODO(emilk): create a better async yield function
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but could use a bit of cleanup for the edge-cases around how we match a URL to a given handler.

crates/re_viewer/src/web.rs Outdated Show resolved Hide resolved
crates/rerun/src/run.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 5e88054 into main Mar 17, 2023
@emilk emilk deleted the emilk/rrd-over-http branch March 17, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📺 re_viewer affects re_viewer itself 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants