Use log as our log backend instead of tracing
#1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make sure the web backend use the correct console.debug etc
emilk
added
🕸️ web
Wumpf
approved these changes
Mar 15, 2023
Comment on lines
+20
to
+23
| if metadata.target().starts_with("wgpu") || metadata.target().starts_with("naga") { | ||
| // TODO(emilk): remove once https://github.com/gfx-rs/wgpu/issues/3206 is fixed | ||
| return metadata.level() <= log::LevelFilter::Warn; | ||
| } |
There was a problem hiding this comment.
Can we think of a good way to opt in to those logs? There are some situations where I want/need them. 🤔
There was a problem hiding this comment.
I can think of a good way: comment out these lines and then recompile!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is so much simpler to write a backend for the
logcrate compared totracing.So this PR also adds a new log backend for the web which uses
console.debugfor debug-level logs,console.warnfor warn level, etc etc. This means we can filter the logs in the browser.Closes #1513
I tried this with all
debug/infospam from wgpu, and there were no web crashes.In the end, I still decided to put the
wgpulog level atwarnbecause of gfx-rs/wgpu#3206Checklist