-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm_bindgen
-caused web crash when using more than 2GiB of RAM
#1513
Comments
Wumpf
added
🪳 bug
Something isn't working
🕸️ web
regarding running the viewer in a browser
💣 crash
crash, deadlock/freeze, do-no-start
labels
Mar 6, 2023
emilk
changed the title
Rapid logging causes web viewer to crash
Rapid text logging to console causes web viewer to crash
Mar 8, 2023
We had this problem when we first switched to the |
I think we should:
|
1 task
This crash still happening on Windows / Chrome.
|
Not confirmed directly yet on this version, but it seems highly likely this was fixed in rustwasm/wasm-bindgen#3310 |
emilk
changed the title
Rapid text logging to console causes web viewer to crash
Mar 16, 2023
wasm_bindgen
-caused web crash when using more than 2GiB of RAM
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're getting fairly weird crashes when sending many log messages per frame.
Most reliable repro for this is running the nyud example on the web from a an rrd file.
cargo run -p rerun --features web_viewer --release -- --web-viewer ../nyud.rrd
We spent already quite a bit of time investigating this, some findings so far:
DynamicResourcePool::alloc
, but whether we log thedesc
there doesn't seem to matterCpuWriteGpuReadBelt
for fast frame by frame memory transfers #1382, butCpuGpuReadBelt
itself doesn't seem to be to blame, but the logs added thereandreas/safe-read-write-belt
has an experiment with a slower butsafe
write belt and it didn't make a difference eitherLink to internal Slack conversation
We should not log as much by default in the browser though! Once log mesages are limited to
info
, the crash disappears.The text was updated successfully, but these errors were encountered: