Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: fix workspace detection #1437

Merged
merged 9 commits into from
Mar 2, 2023
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 28, 2023

Closes #1418

IS_IN_RERUN_WORKSPACE was invisible when building using maturin, but it works in the build.rs scripts.

TODO:

  • Make sure IS_IN_RERUN_WORKSPACE is off for pre-built wheels so our analytics are correct

Checklist

@emilk emilk added 🪳 bug Something isn't working 📊 analytics telemetry analytics 🛞 build wheels labels Feb 28, 2023
@emilk
Copy link
Member Author

emilk commented Feb 28, 2023

No wheels being build 😭

@emilk emilk marked this pull request as ready for review February 28, 2023 18:37
@emilk
Copy link
Member Author

emilk commented Feb 28, 2023

I don't know why the CI doesn't build wheels anymore. It did it for the first few commits on this PR.

Anyways: main is already broken with regards to this, so this PR can only make things better. We can test post-merge (if main CI makes any wheels, that is).

@emilk
Copy link
Member Author

emilk commented Mar 1, 2023

This is confirmed to be working!

@emilk emilk merged commit bebf243 into main Mar 2, 2023
@emilk emilk deleted the emilk/fix-workspace-detection branch March 2, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📊 analytics telemetry analytics 🪳 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IS_IN_RERUN_WORKSPACE env-var isn't working properly
2 participants