Use write belt for mesh data gpu upload #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
Feb 28, 2023
emilk
pushed a commit
that referenced
this pull request
Mar 2, 2023
* Mesh renderer now takes a constant ctx * mesh data upload works now entirely via CpuWriteGpuReadBelt * simplify frame global uniform buffer handling * fix calculating wrong size for mesh vertex buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With that all uniform buffer creation runs by the new utility from #1400.
Mesh creation now passes immutable ctx (needed a little bit more
RwLockfor that).Simplified
FrameGlobalCommandEncodera and made it have a more strictly checked usage pattern.Part of #1398
tested raw_mesh example and re_renderer multiview to confirm things still work
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)