[re_renderer] Uniform buffer utility using CpuWriteGpuReadBelt
#1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🔺 re_renderer
teh-cmc
approved these changes
Feb 26, 2023
| /// But this leads to more unsafe code, harder to avoid holes in write combined memory access | ||
| /// and potentially undefined values in the padding bytes on GPU. | ||
| const CHECK: () = assert!( | ||
| std::mem::align_of::<T>() >= 256, |
There was a problem hiding this comment.
I'd expect an == here?
Suggested change
| std::mem::align_of::<T>() >= 256, | |
| std::mem::align_of::<T>() == 256, |
There was a problem hiding this comment.
Higher alignment is unlikely but absolutely allowed. If something is aligned to 512 we're okay with that as well (but I really hope nothing is!)
Wumpf
deleted the
andreas/re_renderer/fast-and-easy-uniform-buffer-creation
branch
3 tasks
emilk
pushed a commit
that referenced
this pull request
Mar 2, 2023
* utility function for uniform buffer from struct * Uniform buffers are now compile time forced to be 256 bytes aligned * CpuWriteGpuReadBelt no longer takes mutable buffer pool * Renderers and frame_global_command_encoder are now behind locks --------- Co-authored-by: Clement Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for all uniform buffers except meshes - need some more plumbing there, will be done in a follow-up Pr!
This PR introduces a new utility for easy uniform buffer creation & filling. It enforces correct padding - see long comment for details :)
Removes quite a few landmines and makes code in
Renderers shorter!Solves a sizeable chunk of #1398, figured out some
RenderContextshare issues along the wayChecklist
CHANGELOG.md(if this is a big enough change to warrant it)