SDK: stream to disk with save feature
#1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🦀 Rust API
teh-cmc
approved these changes
Feb 26, 2023
Co-authored-by: Clement Rey <[email protected]>
emilk
added a commit
that referenced
this pull request
Mar 2, 2023
* Refactor LogMsg-encoder to be a `struct` * Small cleanup of Sender * Refactor Session: extract the web-viewer connection * Refactor Session::connect * Log SDK: stream log data to file on disk * Rust examples: --save streams to disk * Python examples: start streaming to disk right away * typo Co-authored-by: Clement Rey <[email protected]> --------- Co-authored-by: Clement Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1393
To save an
.rrdfile to disk we would previously buffer all the log messages and then write them all at once at shutdown.Now we do it in a separate thread continuously as the logging program is running.
I also took the opportunity to refactor and simplify
Session.Checklist
CHANGELOG.md(if this is a big enough change to warrant it)