Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SDK save feature should stream to disk #1393

Closed
emilk opened this issue Feb 24, 2023 · 0 comments · Fixed by #1405
Closed

The SDK save feature should stream to disk #1393

emilk opened this issue Feb 24, 2023 · 0 comments · Fixed by #1405
Assignees
@emilk
Labels
enhancement New feature or request 🐍 Python API Python logging API 🦀 Rust API Rust logging API

Comments

@emilk
Copy link
Member

emilk commented Feb 24, 2023

Currently we buffer all log messages and call save at the end. Instead, we should call save(path) before logging, and have the log messages stream to the file.

Advantages:

  • Lower memory use
  • If you program crashes, you still have the rerun log
@emilk emilk added enhancement New feature or request 🐍 Python API Python logging API 🦀 Rust API Rust logging API labels Feb 24, 2023
@emilk emilk self-assigned this Feb 24, 2023
@emilk emilk mentioned this issue Feb 25, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
enhancement New feature or request 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SDK: stream to disk with save feature rerun-io/rerun
1 participant
@emilk