Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More information in --version #1388

Merged
merged 16 commits into from
Feb 26, 2023
Merged

More information in --version #1388

merged 16 commits into from
Feb 26, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 23, 2023

Closes #1310

This introduces two new crates:

  • re_build_info - a struct BuildInfo and a macro to create it
  • re_build_build_info - code to call from build.rs files in order to make re_build_info work
> rerun --version
rerun 0.2.0 aarch64-apple-darwin emilk/build-info 82c669d, built 2023-02-23T20:26:16Z

> python -m rerun --version
rerun_py 0.2.0 aarch64-apple-darwin emilk/build-info 82c669d, built 2023-02-23T20:27:13Z

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk added enhancement New feature or request 🧑‍💻 dev experience developer experience (excluding CI) labels Feb 23, 2023
@emilk emilk mentioned this pull request Feb 24, 2023
Closed
@Wumpf Wumpf self-requested a review February 24, 2023 15:44
Wumpf
Wumpf requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice overall!
But if I'm not mistaken there are some issues in the (moved) code in re_build_build_info

crates/re_build_build_info/src/lib.rs Outdated Show resolved Hide resolved
crates/re_build_build_info/src/lib.rs Outdated Show resolved Hide resolved
crates/re_build_build_info/src/lib.rs Show resolved Hide resolved
@emilk emilk changed the title Better --version More information in --version Feb 25, 2023
@emilk emilk requested a review from Wumpf February 25, 2023 21:55
@emilk emilk merged commit 4f8468a into main Feb 26, 2023
@emilk emilk deleted the emilk/build-info branch February 26, 2023 15:14
@emilk emilk added the 📊 analytics telemetry analytics label Feb 28, 2023
emilk added a commit that referenced this pull request Mar 2, 2023
@emilk
More information in --version (#1388)
705da72 
* Add the re_build_info and re_build_build_info crates

* Add datetime

* --version prints the full build info

* Add git branch and clean/dirty flag

* fix extra --dirty

* Fix analytics link

* Add note about not moving the viewer_analytics.rs file

* Add About-menu with version number, target triplet, and build date

also add link to rerun.io in it

* Add help-button to rerun menu

* Fix web build

* Add crate-level docs

* Rerun re_build_build_info when branch or commit hash changes

* Fix merge-snafu

* Ignore if the repo is dirty or clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc left review comments

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📊 analytics telemetry analytics 🧑‍💻 dev experience developer experience (excluding CI) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add commit hash and date to version numbers, add both to GUI
3 participants
@emilk @Wumpf @teh-cmc