Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re_analytics: track git hash's dirtiness in real-time #925

Closed
teh-cmc opened this issue Jan 25, 2023 · 2 comments
Closed

re_analytics: track git hash's dirtiness in real-time #925

teh-cmc opened this issue Jan 25, 2023 · 2 comments
Labels
🧑‍💻 dev experience developer experience (excluding CI)

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 25, 2023

Right now we're watching .git/refs/heads/** to detect hash changes, but of course this is not enough to detect changes to the repo dirty state as they happen.

@jleibs came up with an evil plan for that:

You could do it with a two-stage process
one build.rs that conditionally updates a file if it changes
and a second build.rs that watches for changes on that file

@emilk
Copy link
Member

emilk commented Feb 24, 2023

Related: #1388

@emilk emilk added the 🧑‍💻 dev experience developer experience (excluding CI) label Feb 24, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Feb 28, 2023

We don't keep track of dirty state no more.

@teh-cmc teh-cmc closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

No branches or pull requests

2 participants