Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture & buffer call now destroy on removal from pool #1359

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 20, 2023

From WebGPU Spec:

An application that no longer requires a GPUTexture can choose to lose access to it before garbage collection by calling destroy().
Note: This allows the user agent to reclaim the GPU memory associated with the GPUTexture once all previously submitted operations using it are complete.

(https://www.w3.org/TR/webgpu/#dom-gputexture-destroy)
(similiar for Buffer https://www.w3.org/TR/webgpu/#buffer-destruction)

Fixes #592

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@Wumpf Wumpf added the 🔺 re_renderer affects re_renderer itself label Feb 20, 2023
@Wumpf Wumpf merged commit 548d269 into main Feb 20, 2023
@Wumpf Wumpf deleted the andreas/re_renderer/resource-destroy-calls branch February 20, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use texture/buffer destroy in resource pool
2 participants