Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use texture/buffer destroy in resource pool #592

Closed
Wumpf opened this issue Dec 18, 2022 · 0 comments · Fixed by #1359
Closed

use texture/buffer destroy in resource pool #592

Wumpf opened this issue Dec 18, 2022 · 0 comments · Fixed by #1359
Assignees
@Wumpf
Labels
enhancement New feature or request 🔺 re_renderer affects re_renderer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented Dec 18, 2022

seems to be a fairly recent addition to WebGPU spec that I wasn't aware of: Textures & Buffers can be explicitly destroyed now! We should use that in our resource pools as we have all the information we need.

https://www.w3.org/TR/webgpu/#dom-gputexture-destroy
https://www.w3.org/TR/webgpu/#dom-gpubuffer-destroy
@Wumpf Wumpf added the 🔺 re_renderer affects re_renderer itself label Dec 18, 2022
@Wumpf Wumpf self-assigned this Dec 18, 2022
Wumpf added a commit that referenced this issue Dec 18, 2022
@Wumpf
allow buffers to be mapped on creation,
c025191 
add resource destruction callback
Fixes #592
Wumpf added a commit that referenced this issue Dec 18, 2022
@Wumpf
allow buffers to be mapped on creation,
5c1ca3d 
add resource destruction callback
Fixes #592
Wumpf added a commit that referenced this issue Dec 18, 2022
@Wumpf
allow buffers to be mapped on creation,
a587ef3 
add resource destruction callback
Fixes #592
Wumpf added a commit that referenced this issue Dec 18, 2022
@Wumpf
allow buffers to be mapped on creation,
3abfbbd 
add resource destruction callback
Fixes #592
Wumpf added a commit that referenced this issue Dec 18, 2022
@Wumpf
allow buffers to be mapped on creation,
e7cbf61 
add resource destruction callback
Fixes #592
@Wumpf Wumpf mentioned this issue Dec 18, 2022
Closed
8 tasks
@Wumpf Wumpf added the enhancement New feature or request label Dec 25, 2022
Wumpf added a commit that referenced this issue Feb 20, 2023
@Wumpf
Texture & buffer call now destroy on removal from pool
9960eb9 
Fixes #592
Wumpf added a commit that referenced this issue Feb 20, 2023
@Wumpf
Texture & buffer call now destroy on removal from pool
3a3ef86 
Fixes #592
@Wumpf Wumpf mentioned this issue Feb 20, 2023
Merged
3 tasks
Wumpf added a commit that referenced this issue Feb 20, 2023
@Wumpf
Texture & buffer call now destroy on removal from pool (#1359)
548d269 
Fixes #592
Wumpf added a commit that referenced this issue Feb 20, 2023
@Wumpf
Texture & buffer call now destroy on removal from pool
d9b4774 
Fixes #592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
enhancement New feature or request 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
1 participant
@Wumpf