-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some links #1314
Merged
Merged
Fix some links #1314
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -143,7 +143,7 @@ jobs: | |
run: rustup target add wasm32-unknown-unknown && cargo install wasm-bindgen-cli --version 0.2.84 | ||
|
||
# The last step of setup_web.sh, for Windows. | ||
# Since 'winget' is not available within the github runner, we download the package directly: | ||
# Since 'winget' is not available within the GitHub runner, we download the package directly: | ||
# See: https://github.com/marketplace/actions/engineerd-configurator | ||
- name: Install binaryen for building the web-viewer Wasm on windows | ||
if: matrix.platform == 'windows' | ||
|
@@ -235,7 +235,7 @@ jobs: | |
name: wheels | ||
path: dist | ||
|
||
- name: Github Release | ||
- name: GitHub Release | ||
uses: softprops/[email protected] | ||
with: | ||
body: ${{ env.PRE_RELEASE_INSTRUCTIONS }} | ||
|
@@ -262,7 +262,7 @@ jobs: | |
name: wheels | ||
path: dist | ||
|
||
- name: Github Release | ||
- name: GitHub Release | ||
uses: softprops/[email protected] | ||
with: | ||
prerelease: false | ||
|
@@ -273,7 +273,7 @@ jobs: | |
- name: Publish to PyPI | ||
uses: PyO3/maturin-action@v1 | ||
env: | ||
# These are both set in the Github project configuration | ||
# These are both set in the GitHub project configuration | ||
MATURIN_REPOSITORY: ${{ vars.PYPI_REPOSITORY }} | ||
MATURIN_PYPI_TOKEN: ${{ secrets.MATURIN_PYPI_TOKEN }} | ||
with: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ It lets you debug and understand the internal state and data of your systems wit | |
pip3 install rerun-sdk | ||
``` | ||
|
||
ℹ️ Note: | ||
ℹ️ Note: | ||
The Python module is called `rerun`, while the package published on PyPI is `rerun-sdk`. | ||
|
||
## Example | ||
|
@@ -32,8 +32,9 @@ rr.log_points("my_points", positions=positions, colors=colors) | |
|
||
## Resources | ||
* [Quick start](https://www.rerun.io/docs/getting-started/python) | ||
* [Python API docs](https://ref.rerun.io/docs/python) | ||
* [Tutorial](https://www.rerun.io/docs/getting-started/logging-python) | ||
* [Examples on Github](https://github.com/rerun-io/rerun/tree/latest/examples/python) | ||
* [Examples on GitHub](https://github.com/rerun-io/rerun/tree/latest/examples/python) | ||
* [Troubleshooting](https://www.rerun.io/docs/getting-started/troubleshooting) | ||
* [Discord Server](https://discord.com/invite/Gcm8BbTaAj) | ||
|
||
|
@@ -55,7 +56,7 @@ python3 examples/python/car/main.py --connect | |
|
||
# From Source | ||
|
||
Checkout the [Github repository](https://github.com/rerun-io/rerun): | ||
Checkout the [GitHub repository](https://github.com/rerun-io/rerun): | ||
```sh | ||
git clone [email protected]:rerun-io/rerun.git | ||
``` | ||
|
@@ -68,7 +69,7 @@ python3 -m pip install --upgrade pip | |
pip3 install maturin "./rerun_py" | ||
``` | ||
|
||
ℹ️ Note: | ||
ℹ️ Note: | ||
If you are unable to upgrade pip to version `>=21.3`, you need to pass `--use-feature=in-tree-build` to the `pip3 install` command. | ||
|
||
## Development | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would CONTRIBUTING.md be spared tho?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODE_STYLE mentions how NOT to write
TODO
, and so it triggers those lintsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooo it's an exclude, I see