-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some links #1314
Fix some links #1314
Conversation
I'm doing the same over at rerun-docs too |
|
||
exclude_dirs = {"env", "venv", "target", "target_ra", "target_wasm"} | ||
|
||
exclude_paths = { | ||
"./CONTRIBUTING.md", | ||
"./CODE_STYLE.md", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would CONTRIBUTING.md be spared tho?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODE_STYLE mentions how NOT to write TODO
, and so it triggers those lints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooo it's an exclude, I see
Please double-check this, because I'm really tired |
Sibling PR: rerun-io/rerun-docs#42 |
Also write "GitHub" instead of "Github" everywhere.
Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)