Skip to content

Fix some actions happening on key _up_ instead of key _down_#10232

Merged
Wumpf merged 3 commits intomainfrom
emilk/update-egui-with-input-fix
Jun 16, 2025
Merged

Fix some actions happening on key _up_ instead of key _down_#10232
Wumpf merged 3 commits intomainfrom
emilk/update-egui-with-input-fix

Conversation

@emilk
Copy link
Member

@emilk emilk commented Jun 15, 2025

Related

Updated snapshot images

For some reason, the more buttons has become slightly sharper. Maybe related to the recent atomics work?

@emilk emilk added 📺 re_viewer affects re_viewer itself dependencies concerning crates, pip packages etc include in changelog egui Requires egui/eframe work Bug labels Jun 15, 2025
@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
1b955c9 https://rerun.io/viewer/pr/10232 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think only the more icon changed because it's not a perfect square: width="15" height="14"

@Wumpf Wumpf merged commit 52b2dcd into main Jun 16, 2025
40 checks passed
@Wumpf Wumpf deleted the emilk/update-egui-with-input-fix branch June 16, 2025 07:33
@Wumpf Wumpf added 🪳 bug Something isn't working and removed Bug labels Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working dependencies concerning crates, pip packages etc egui Requires egui/eframe work include in changelog 📺 re_viewer affects re_viewer itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No repaint on key press?

3 participants