Fix missing repaint after consume_key#7134
Merged
lucasmerlin merged 2 commits intomainfrom Jun 13, 2025
Merged
Conversation
lucasmerlin
force-pushed
the
lucas/fix-missing-repaint-after-consume-key
branch
from
8b8fc66 to
522f4f3
Compare
|
Preview available at https://egui-pr-preview.github.io/pr/7134-lucasfix-missing-repaint-after-consume-key |
emilk
reviewed
Jun 11, 2025
emilk
approved these changes
Jun 12, 2025
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
LGTM if tested!
Thanks for taking this
bircni
approved these changes
Jun 12, 2025
Wumpf
added a commit
to rerun-io/rerun
that referenced
this pull request
Jun 16, 2025
### Related * Closes #10165 * Includes emilk/egui#7134 * All changes: emilk/egui@f0abce9...54fded3 ### Updated snapshot images For some reason, the `…` more buttons has become slightly sharper. Maybe related to the recent atomics work? --------- Co-authored-by: Andreas Reich <andreas@rerun.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually input events automatically trigger a repaint. But since consume_key would remove the event egui would think there were no events and not trigger a repaint. This fixes it by setting a flag on InputState on consume_key.