Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe: re-design UI based on new query model #7497

Closed
abey79 opened this issue Sep 24, 2024 · 0 comments
Closed

Dataframe: re-design UI based on new query model #7497

abey79 opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
🧑‍🎨 Design Requires UX/UI designer input feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Sep 24, 2024

The goal of this redesign is to keep up with the changes being introduced in the data APIs #7455.

Overview: the is organised as a fixed pipeline of optional stages, where each stage corresponds to some primitive of the data API.

Stages:

  • View (required): the subset of the datastore on which the rest of the filtering/querying happens.
    • content: entity path filter
    • timeline: the timeline used by everything else
  • Filter: time range (optional): only keep rows whose timestamps on the view timeline are within the provided range.
    • start: low bound, can be set to -inf
    • end: high bound, can be set to +inf
  • Filter: events (optional): only keep rows which contains a logging event for the specified column (formerly known as PoV).
    • entity: the column entity (must be one of the view's entity)
    • component: the column component (must be on of the specified entity)
  • Fill with latest-at (bool, optional): whether or not null cells are filled using latest-at queries.
  • Select (list of columns): for each view column, whether or not it is included or not in the final dataframe.
    • Helper to select all or nothing, or a recommended subset would be nice.

Notes:

  • All components for the view entities are included in the view. It is not possible to further restrict this (like you can with the API).
  • The dataframe view doesn't allow combing multiple filter_events_for. There is 0 or 1 active at a time.
  • The dataframe view doesn't expose anything about custom time values (e.g. filter_time, latest_at_times).
@abey79 abey79 added feat-dataframe-view Everything related to the dataframe view 🧑‍🎨 Design Requires UX/UI designer input ui concerns graphical user interface labels Sep 24, 2024
@abey79 abey79 added this to the 0.19 - Dataframe and web video milestone Sep 24, 2024
abey79 added a commit that referenced this issue Oct 3, 2024
…he new query property (#7516)

### What

This PR introduces a new `DataframeQueryV2` view property archetype
which models the query according to the new dataframe API design
(#7455) and the feature we
actually want to support in the dataframe view
(#7497).

At this point, the new archetype is **NOT** used yet. It just lives
alongside the previous iteration, which is still used by the actual
view. The swap will occur later.

<hr>

Part of a series to address #6896 and #7498.

All PRs:
- #7515
- #7516
- #7527 
- #7545
- #7551
- #7572
- #7573

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7516?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7516?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7516)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@abey79 abey79 closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍🎨 Design Requires UX/UI designer input feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

2 participants