Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe view update and blueprint API (part 0): introduce view object and improve doc generation #7515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Sep 25, 2024

What

This PR introduces a stub blueprint view object for the dataframe view. It doesn't contain any actual parameters (query, etc.), but is sufficient to "spawn" a view. This PR also improves doc generation by special casing the dataframe view (it accepts all archetypes and inversely).

(Note: the snippet will be much improved in later PRs.)

image

image


Part of a series to address #6896 and #7498.

All PRs:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link

github-actions bot commented Sep 25, 2024

Deployed docs

Commit Link
14f487f https://landing-hzn2iqsvj-rerun.vercel.app/docs

@abey79 abey79 added 🟦 blueprint The data that defines our UI ui concerns graphical user interface feat-dataframe-view Everything related to the dataframe view 🐍 Python API Python logging API labels Sep 25, 2024
@abey79 abey79 changed the title Dataframe view update and blueprint API (part 0): introduce view object and improve doc codegen Dataframe view update and blueprint API (part 0): introduce view object and improve doc generation Sep 25, 2024
@abey79 abey79 marked this pull request as ready for review September 30, 2024 12:17
@abey79 abey79 removed the do-not-merge Do not merge this PR label Sep 30, 2024
@Wumpf Wumpf self-requested a review October 1, 2024 09:52
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI do-not-merge Do not merge this PR feat-dataframe-view Everything related to the dataframe view include in changelog 🐍 Python API Python logging API ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants