Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove left panel workaround #6256

Closed
abey79 opened this issue May 7, 2024 · 0 comments · Fixed by #6593
Closed

Remove left panel workaround #6256

abey79 opened this issue May 7, 2024 · 0 comments · Fixed by #6593
Labels
ui concerns graphical user interface
Milestone
0.17

Comments

@abey79
Copy link
Member

abey79 commented May 7, 2024

#6255 introduced a workaround for emilk/egui#4475 which should be cleaned when egui is fixed. This should also fix the remaining glitch from #6227:

image
@abey79 abey79 added the ui concerns graphical user interface label May 7, 2024
@abey79 abey79 mentioned this issue May 7, 2024
Merged
5 tasks
abey79 added a commit that referenced this issue May 8, 2024
@abey79
Fix visual glitch when extending the time panel (#6255)
bc062e4 
### What

- Fixes #6227

A workaround for emilk/egui#4475 was needed
that will need to be cleaned:
- #6256

**NOTE**: chained to #6248 to minimise conflicts.

Note that this doesn't _entirely_ fix the visual glitch, but makes it
much less visible. Now the time panel must be disproportionately be
stretched _and_ one must hover the separator:

<img width="445" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/d66ccccb-2a22-4d00-bb8e-7c020c806928">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6255?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6255?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6255)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@emilk emilk mentioned this issue Jun 19, 2024
Merged
5 tasks
@emilk emilk added this to the 0.17 milestone Jun 19, 2024
@emilk emilk closed this as completed in 0fe47d1 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
0.17
Development

Successfully merging a pull request may close this issue.

Update to latest egui master rerun-io/rerun
2 participants
@emilk @abey79