New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time panel vs. timeseries space view sizing glitch #6227

Closed

abey79 opened this issue May 6, 2024 · 1 comment · Fixed by #6255

Assignees

Labels

ui

Milestone

Member

abey79 commented May 6, 2024

time-panel-size.mp4

abey79 added the ui label

abey79 added this to the 0.16 milestone

abey79 mentioned this issue

SidePanel frame leaks into BottomPanel emilk/egui#4475

Closed

Member Author

abey79 commented May 7, 2024

Caused by emilk/egui#4475

This was referenced May 7, 2024

Fix visual glitch when extending the time panel #6255

Merged

Remove left panel workaround #6256

Closed

Wumpf assigned abey79

abey79 added a commit that referenced this issue


          Fix visual glitch when extending the time panel (#6255)

bc062e4

### What

- Fixes #6227

A workaround for emilk/egui#4475 was needed
that will need to be cleaned:
- #6256

**NOTE**: chained to #6248 to minimise conflicts.

Note that this doesn't _entirely_ fix the visual glitch, but makes it
much less visible. Now the time panel must be disproportionately be
stretched _and_ one must hover the separator:

<img width="445" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/d66ccccb-2a22-4d00-bb8e-7c020c806928">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6255?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6255?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6255)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

abey79 closed this as completed in #6255

emilk mentioned this issue

Update to latest egui master #6593

Merged

5 tasks

emilk added a commit that referenced this issue


          Update to latest egui master (#6593)

0fe47d1

### What
* Update to latest egui, including
emilk/egui#4676 (among other things)
* Removes workaround for #6227
added in #6255
* Closes #6256

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6593?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6593?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6593)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment