Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "Store ID" in the UI #4647

Closed
nikolausWest opened this issue Jan 3, 2024 · 4 comments · Fixed by #4761
Closed

Don't use "Store ID" in the UI #4647

nikolausWest opened this issue Jan 3, 2024 · 4 comments · Fixed by #4761
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Milestone

Comments

@nikolausWest
Copy link
Member

When hovering a recording, in the recordings list, the on hover UI summary says "Store ID", which is an internal concept that should not be leaked to users. In this case it should instead be called "Recording ID", which matches the parameter recording_id in the SDKs.

Screenshot 2024-01-03 at 10 44 55

@nikolausWest nikolausWest added ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less labels Jan 3, 2024
@nikolausWest nikolausWest added this to the Triage milestone Jan 3, 2024
@RohanMishra315
Copy link

Hey @nikolausWest Can I take a look at it ? can you tell where Ui files are ?

@nikolausWest
Copy link
Member Author

I don't know my way around that code but perhaps @emilk or @Wumpf does?

@emilk
Copy link
Member

emilk commented Jan 8, 2024

It's in crates/re_viewer/src/ui/recordings_panel.rs:

❯ rg "Store ID"
crates/re_viewer/src/ui/recordings_panel.rs
249:            re_ui.grid_left_hand_label(ui, "Store ID");

@emilk emilk self-assigned this Jan 9, 2024
@emilk
Copy link
Member

emilk commented Jan 9, 2024

I'm fixing this as part of #4649

emilk added a commit that referenced this issue Jan 10, 2024
### What
* Closes #4647
* Closes #4649

You can now click a recording to select it (show info about it in the
selection panel).


![select-recording](https://github.com/rerun-io/rerun/assets/1148717/c0928e97-a538-4f60-9308-da65f33c51a6)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4761/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4761/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4761/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4761)
- [Docs
preview](https://rerun.io/preview/482599187dd686bfa0e1c4709ed090d6e84c3c9d/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/482599187dd686bfa0e1c4709ed090d6e84c3c9d/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants