-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Click a recording to select it (#4761)
### What * Closes #4647 * Closes #4649 You can now click a recording to select it (show info about it in the selection panel). ![select-recording](https://github.com/rerun-io/rerun/assets/1148717/c0928e97-a538-4f60-9308-da65f33c51a6) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4761/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4761/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4761/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4761) - [Docs preview](https://rerun.io/preview/482599187dd686bfa0e1c4709ed090d6e84c3c9d/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/482599187dd686bfa0e1c4709ed090d6e84c3c9d/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
- Loading branch information
Showing
21 changed files
with
312 additions
and
204 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
impl crate::DataUi for re_entity_db::EntityDb { | ||
fn data_ui( | ||
&self, | ||
ctx: &re_viewer_context::ViewerContext<'_>, | ||
ui: &mut egui::Ui, | ||
verbosity: re_viewer_context::UiVerbosity, | ||
_query: &re_data_store::LatestAtQuery, | ||
) { | ||
let re_ui = &ctx.re_ui; | ||
|
||
if verbosity == re_viewer_context::UiVerbosity::Small { | ||
let mut string = self.store_id().to_string(); | ||
if let Some(data_source) = &self.data_source { | ||
string += &format!(", {data_source}"); | ||
} | ||
if let Some(store_info) = self.store_info() { | ||
string += &format!(", {}", store_info.application_id); | ||
} | ||
ui.label(string); | ||
return; | ||
} | ||
|
||
egui::Grid::new("entity_db").num_columns(2).show(ui, |ui| { | ||
re_ui.grid_left_hand_label(ui, &format!("{} ID", self.store_id().kind)); | ||
ui.label(self.store_id().to_string()); | ||
ui.end_row(); | ||
|
||
if let Some(data_source) = &self.data_source { | ||
re_ui.grid_left_hand_label(ui, "Data source"); | ||
ui.label(data_source.to_string()); | ||
ui.end_row(); | ||
} | ||
|
||
if let Some(store_info) = self.store_info() { | ||
let re_log_types::StoreInfo { | ||
application_id, | ||
store_id: _, | ||
is_official_example: _, | ||
started, | ||
store_source, | ||
store_kind, | ||
} = store_info; | ||
|
||
re_ui.grid_left_hand_label(ui, "Application ID"); | ||
ui.label(application_id.to_string()); | ||
ui.end_row(); | ||
|
||
re_ui.grid_left_hand_label(ui, "Recording started"); | ||
ui.label(started.format(ctx.app_options.time_zone_for_timestamps)); | ||
ui.end_row(); | ||
|
||
re_ui.grid_left_hand_label(ui, "Source"); | ||
ui.label(store_source.to_string()); | ||
ui.end_row(); | ||
|
||
// We are in the recordings menu, we know the kind | ||
if false { | ||
re_ui.grid_left_hand_label(ui, "Kind"); | ||
ui.label(store_kind.to_string()); | ||
ui.end_row(); | ||
} | ||
} | ||
}); | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
impl crate::DataUi for re_log_types::StoreId { | ||
fn data_ui( | ||
&self, | ||
ctx: &re_viewer_context::ViewerContext<'_>, | ||
ui: &mut egui::Ui, | ||
verbosity: re_viewer_context::UiVerbosity, | ||
query: &re_data_store::LatestAtQuery, | ||
) { | ||
if let Some(entity_db) = ctx.store_context.recording(self) { | ||
entity_db.data_ui(ctx, ui, verbosity, query); | ||
} else { | ||
ui.label(format!("{} ID {} (not found)", self.kind, self.id)); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.