-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default plot bounds are broken #4503
Labels
🪳 bug
Something isn't working
egui
Requires egui/eframe work
📺 re_viewer
affects re_viewer itself
ui
concerns graphical user interface
Milestone
Comments
emilk
added
🪳 bug
Something isn't working
ui
concerns graphical user interface
📺 re_viewer
affects re_viewer itself
labels
Dec 12, 2023
Seems to be all of egui_plot: https://www.egui.rs/ |
Will be fixed by emilk/egui#3722 |
Wumpf
pushed a commit
to emilk/egui
that referenced
this issue
Dec 19, 2023
These PR recently cleaned up the code around auto-bounds, but introduced an involuntary change whereby auto-bounds would not be enabled by default. All plots would default to being not properly centred as a result. - #3587 - #3586 This PR changes the default back to enabled. It also deprecates `auto_bounds_x()` and `auto_bounds_y()`, which could only enable auto-bounds (which is not very useful as auto-bounds were, and now are again, enabled by default). A new `auto_bounds()` API can now be sued to disable auto-bounds if needed. Fixes #3712 Fixes rerun-io/rerun#4503
emilk
pushed a commit
to emilk/egui
that referenced
this issue
Jan 3, 2024
These PR recently cleaned up the code around auto-bounds, but introduced an involuntary change whereby auto-bounds would not be enabled by default. All plots would default to being not properly centred as a result. - #3587 - #3586 This PR changes the default back to enabled. It also deprecates `auto_bounds_x()` and `auto_bounds_y()`, which could only enable auto-bounds (which is not very useful as auto-bounds were, and now are again, enabled by default). A new `auto_bounds()` API can now be sued to disable auto-bounds if needed. Fixes #3712 Fixes rerun-io/rerun#4503
emilk
pushed a commit
to emilk/egui_plot
that referenced
this issue
Jul 15, 2024
These PR recently cleaned up the code around auto-bounds, but introduced an involuntary change whereby auto-bounds would not be enabled by default. All plots would default to being not properly centred as a result. - #3587 - #3586 This PR changes the default back to enabled. It also deprecates `auto_bounds_x()` and `auto_bounds_y()`, which could only enable auto-bounds (which is not very useful as auto-bounds were, and now are again, enabled by default). A new `auto_bounds()` API can now be sued to disable auto-bounds if needed. Fixes #3712 Fixes rerun-io/rerun#4503
Hasenfellvy
added a commit
to Hasenfellvy/egui_plot
that referenced
this issue
Aug 27, 2024
These PR recently cleaned up the code around auto-bounds, but introduced an involuntary change whereby auto-bounds would not be enabled by default. All plots would default to being not properly centred as a result. - #3587 - #3586 This PR changes the default back to enabled. It also deprecates `auto_bounds_x()` and `auto_bounds_y()`, which could only enable auto-bounds (which is not very useful as auto-bounds were, and now are again, enabled by default). A new `auto_bounds()` API can now be sued to disable auto-bounds if needed. Fixes #3712 Fixes rerun-io/rerun#4503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🪳 bug
Something isn't working
egui
Requires egui/eframe work
📺 re_viewer
affects re_viewer itself
ui
concerns graphical user interface
run
./examples/python/plots/main.py
or visit https://app.rerun.io/commit/ab2b047/?url=https://app.rerun.io/commit/ab2b047/examples/plots.rrd and you'll seeThe text was updated successfully, but these errors were encountered: