Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui_plot auto-bounds broken #3712

Closed
emilk opened this issue Dec 18, 2023 · 0 comments · Fixed by #3722
Closed

egui_plot auto-bounds broken #3712

emilk opened this issue Dec 18, 2023 · 0 comments · Fixed by #3722
Assignees
Labels
bug Something is broken egui_plot Related to egui_plot rerun Desired for Rerun.io

Comments

@emilk
Copy link
Owner

emilk commented Dec 18, 2023

Repro: try the plots demo at https://www.egui.rs/ - you need to double-click most of the plots for them to reset to a nice default.

Reverting #3586 fixes the problem

@abey79

@emilk emilk added bug Something is broken egui_plot Related to egui_plot labels Dec 18, 2023
@emilk emilk added this to the 0.25.0 milestone Dec 18, 2023
@emilk emilk added the rerun Desired for Rerun.io label Dec 18, 2023
abey79 added a commit that referenced this issue Dec 19, 2023
Wumpf pushed a commit that referenced this issue Dec 19, 2023
These PR recently cleaned up the code around auto-bounds, but introduced
an involuntary change whereby auto-bounds would not be enabled by
default. All plots would default to being not properly centred as a
result.

- #3587
- #3586

This PR changes the default back to enabled. It also deprecates
`auto_bounds_x()` and `auto_bounds_y()`, which could only enable
auto-bounds (which is not very useful as auto-bounds were, and now are
again, enabled by default). A new `auto_bounds()` API can now be sued to
disable auto-bounds if needed.

Fixes #3712 
Fixes rerun-io/rerun#4503
emilk pushed a commit that referenced this issue Jan 3, 2024
These PR recently cleaned up the code around auto-bounds, but introduced
an involuntary change whereby auto-bounds would not be enabled by
default. All plots would default to being not properly centred as a
result.

- #3587
- #3586

This PR changes the default back to enabled. It also deprecates
`auto_bounds_x()` and `auto_bounds_y()`, which could only enable
auto-bounds (which is not very useful as auto-bounds were, and now are
again, enabled by default). A new `auto_bounds()` API can now be sued to
disable auto-bounds if needed.

Fixes #3712 
Fixes rerun-io/rerun#4503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui_plot Related to egui_plot rerun Desired for Rerun.io
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants