Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to skip the "latest_at" semantics with range queries #4192

Closed
abey79 opened this issue Nov 9, 2023 · 2 comments
Closed

Add support to skip the "latest_at" semantics with range queries #4192

abey79 opened this issue Nov 9, 2023 · 2 comments
Labels
🔩 data model 🔍 re_query affects re_query itself

Comments

@abey79
Copy link
Member

abey79 commented Nov 9, 2023

For $REASONS, "empty" range queries exhibit the "latest at" semantics.

In some case, this is questionable:

image

In other case, this is outright problematic:

visible_history_range_query_latest_at_issue.mp4

Range queres without the "latest at" semantics should possible, and used at least in TimeSeriesSystem::load_scalars().

@abey79 abey79 added 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 9, 2023
@abey79 abey79 added 🔍 re_query affects re_query itself 🔩 data model and removed 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 9, 2023
@teh-cmc
Copy link
Member

teh-cmc commented Nov 10, 2023

Should not be too hard to add a switch for this in RangeQuery:

 pub struct RangeQuery {
     pub timeline: Timeline,
     pub range: TimeRange,
+
+    /// Should the result include the latest compacted state at `range.min`?
+    pub include_latest: bool,
 }

abey79 added a commit that referenced this issue Nov 10, 2023
### What

- Add support for Visible History to Timeseries space views
- Needed to introduce `DataStore::entity_min_time()` to maintain the
consistent "beginning of x axis" behaviour.
- Changes the way the Visible History feature is organised:
- Now all space view (blueprint) contain a "root entity properties"
structure that is cascaded to the enclosed groups and entities.
- The visible history part of that root entity props is editable for all
supported space view classes (now 2d, 3d, and timeseries).
- The rest is unchanged: this means that contrary to the plan it's also
possible to edit the visible history on a per-entity basis in timeseries
space views as well.

-  Closes #2547

#### Known limitations
- default value for `EntityProperty` is not ideal for entities in
timeseries space view (2x `Relative(0)`)
- #4192

#### TODO

- [x] freeze the plot display bounds while the time cursor is dragged
- [x] setting must be serialised to blueprint


https://github.com/rerun-io/rerun/assets/49431240/5bc6033d-54d4-4376-845b-81189f3c5bb7

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4179) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4179)
- [Docs
preview](https://rerun.io/preview/8c2be673a26cff49e76942bf99b06c4b76957774/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/8c2be673a26cff49e76942bf99b06c4b76957774/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@teh-cmc
Copy link
Member

teh-cmc commented Mar 15, 2024

Range queries don't have this weird behavior anymore (they are now multi-tenant proof).

@teh-cmc teh-cmc closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model 🔍 re_query affects re_query itself
Projects
None yet
Development

No branches or pull requests

2 participants