Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set a sliding window for time series plots (aka support the Visible History feature) #2547

Closed
Tracked by #4107
Wumpf opened this issue Jun 28, 2023 · 1 comment · Fixed by #4179
Closed
Tracked by #4107

Allow to set a sliding window for time series plots (aka support the Visible History feature) #2547

Wumpf opened this issue Jun 28, 2023 · 1 comment · Fixed by #4179
Assignees
@abey79
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself ui concerns graphical user interface user-request This is a pressing issue for one of our users

Comments

@Wumpf
Copy link
Member

Wumpf commented Jun 28, 2023

Right now time series plots always show the entire plot at once.
It would be very useful to have a fixed length window into the plot that slides along as time passes.
@Wumpf Wumpf added enhancement New feature or request 📺 re_viewer affects re_viewer itself user-request This is a pressing issue for one of our users labels Jun 28, 2023
@nikolausWest nikolausWest mentioned this issue Oct 19, 2023
Closed
@abey79 abey79 mentioned this issue Nov 2, 2023
Open
21 tasks
@abey79 abey79 changed the title Allow to set a sliding window for time series plots Allow to set a sliding window for time series plots (aka support the Visible History feature) Nov 2, 2023
@abey79
Copy link
Member

abey79 commented Nov 3, 2023

The plan is to add this at the space view level (instead of datagroups/entities like in 2d/3d space views).

@abey79 abey79 added the ui concerns graphical user interface label Nov 6, 2023
@abey79 abey79 mentioned this issue Nov 8, 2023
Merged
6 tasks
abey79 added a commit that referenced this issue Nov 10, 2023
@abey79
Add support for Visible History to time series space views (#4179)
a4cf644 
### What

- Add support for Visible History to Timeseries space views
- Needed to introduce `DataStore::entity_min_time()` to maintain the
consistent "beginning of x axis" behaviour.
- Changes the way the Visible History feature is organised:
- Now all space view (blueprint) contain a "root entity properties"
structure that is cascaded to the enclosed groups and entities.
- The visible history part of that root entity props is editable for all
supported space view classes (now 2d, 3d, and timeseries).
- The rest is unchanged: this means that contrary to the plan it's also
possible to edit the visible history on a per-entity basis in timeseries
space views as well.

-  Closes #2547

#### Known limitations
- default value for `EntityProperty` is not ideal for entities in
timeseries space view (2x `Relative(0)`)
- #4192

#### TODO

- [x] freeze the plot display bounds while the time cursor is dragged
- [x] setting must be serialised to blueprint


https://github.com/rerun-io/rerun/assets/49431240/5bc6033d-54d4-4376-845b-81189f3c5bb7

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4179) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4179)
- [Docs
preview](https://rerun.io/preview/8c2be673a26cff49e76942bf99b06c4b76957774/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/8c2be673a26cff49e76942bf99b06c4b76957774/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself ui concerns graphical user interface user-request This is a pressing issue for one of our users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Visible History to time series space views rerun-io/rerun
2 participants
@Wumpf @abey79