Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling save last prevents python script from exiting #3907

Closed
Wumpf opened this issue Oct 17, 2023 · 0 comments
Closed

Calling save last prevents python script from exiting #3907

Wumpf opened this issue Oct 17, 2023 · 0 comments
Assignees
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🐍 Python API Python logging API user-request This is a pressing issue for one of our users
Milestone

Comments

@Wumpf
Copy link
Member

Wumpf commented Oct 17, 2023

This tiny little script gets stuck, worse though the application won't respond to sigint (ctrl+c)

import rerun as rr

rr.init("pointcloud", spawn=False)
rr.log("world/pointcloud", rr.Points3D(positions=[[1,2,3]], colors = [255, 255, 255], radii=0.001))
rr.save("test.rrd")

This however works fine:

import rerun as rr

rr.init("pointcloud", spawn=False)
rr.save("test2.rrd")
rr.log("world/pointcloud", rr.Points3D(positions=[[1,2,3]], colors = [255, 255, 255], radii=0.001))
@Wumpf Wumpf added 🪳 bug Something isn't working 🐍 Python API Python logging API 💣 crash crash, deadlock/freeze, do-no-start user-request This is a pressing issue for one of our users labels Oct 17, 2023
@Wumpf Wumpf added this to the 0.10 Polish (non-blocking) milestone Oct 17, 2023
@jleibs jleibs self-assigned this Oct 18, 2023
jleibs added a commit that referenced this issue Oct 19, 2023
…f a Python program (#3920)

### What
Certain edge cases of changing the sink can cause an internal flush,
which is known to cause potential deadlocks when dropping python
datastructures.

Release the GIL under .save(), .connect(), and .memory().

Resolves:
 - #3907

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3920) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3920)
- [Docs
preview](https://rerun.io/preview/c5bcfffb3612a6ede8c94a8d05894155e56bbe15/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/c5bcfffb3612a6ede8c94a8d05894155e56bbe15/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@Wumpf Wumpf closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🐍 Python API Python logging API user-request This is a pressing issue for one of our users
Projects
None yet
Development

No branches or pull requests

2 participants